Open
Conversation
a-card
commented
Jul 30, 2018
a-card
commented
- The code is still compatible with Python 2.
- Switched to using 'with' to handle ISF file opening/closing
- Removed unnecessary ISF filetype check. Tested using this exact type of ISF file.
- Removed trailing whitespace
added 2 commits
July 30, 2018 12:50
The code is still Python 2 compaitble. Had to switch to over to reading data in as raw bytes. Also switched over to using 'with' to open the file. Removed trailing whitespaces.
Tested this by reading an ISF file that matched the 'non-compatible' ISF file type. Turns out isfread is in fact compatible with these parameters.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.