make py3 default, added bytenum 1 reading#4
Conversation
|
Hi RA, Thank you for the commit. I will review it shortly. I began working on this code some time ago, I noticed you explicitly mentioned the 'a-card' branch. Could you please elaborate on why this mention is necessary? I noticed that several lines have been removed from the original isfread_py3.py. Before accepting these changes, I'll need to check what they do. Do you want me to mention you in code as RA, or would you prefer a more explicit mention? Thank you again, and I am open to any suggestions. Please note that English is not my native language. Feel free to respond by email if you prefer. My email is included in the .py files. |
|
Hi Gustavo, thank you for your quick response that I noticed only now. The a-card fork was mentioned by me, because from one of the older py3 versions I took the idea to use the with statement for fileInput opening. (Then closing takes places automatically, so Later on I merged this back to your py3 version for my own use. There are no removed lines compared to your code! I shifted the There is only the different way of file opening (with implicit, automatic closing of If you want you can mention my contribution with my full name. It's not absolutely necessary to keep this mention in the author tag or in the file at all. There is still the git log ... Thank you for your work to provide isfread for python! Regards |
Hi,
I would suggest to flip module names, because Python3 should be de facto the standard version now.
There is a fix in new
isfread.py(formerlyisfread_py3.py, so that a specific data example from current TBS1000C, which hasBYT_Nequal to 1, was converted apparently without errors.