Skip to content
This repository was archived by the owner on Oct 15, 2020. It is now read-only.

Conversation

@davidsteinsland
Copy link

Also removed the newline implosion. The whole idea is to compress the input, not make it larger again.

@DerDu
Copy link

DerDu commented Mar 13, 2013

NEVER EVER use this syntax

$var = []; 

INSTEAD OF

$var = array();
  • it's NOT valid php 5 .... it's php 5.4 ONLY
  • most IDE's can't handle it, so its harder to spot/refactor/etc..
  • its not backward compatible

@davidsteinsland
Copy link
Author

True that, but seeing that PHP 5.4 is out in its 12th release, I don't see the problem. My opinion is that PHP 5.4 should be standard on most hosts now, but you are free to merge anything you want.

@bkdotcom
Copy link

re: newline implosion
see the 'linebreak' option (the --line-break option)
the idea is to return the output that the command line returns (if it's returning "\n"s we shouldn't remove them)
and to maintain the linebreaks in the verbose output

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants