Chore: Support openai o1 model #937
Conversation
pkg/openai/client.go
Outdated
|
|
||
| if len(systemPrompts) > 0 { | ||
| role := types.CompletionMessageRoleTypeSystem | ||
| if useO1Model { |
There was a problem hiding this comment.
According to docs, for o1 model it is better to use developer message.
https://platform.openai.com/docs/guides/reasoning#advice-on-prompting
pkg/openai/client.go
Outdated
| return &result, nil | ||
| } | ||
|
|
||
| func isO1Model(model string, envs []string) bool { |
There was a problem hiding this comment.
there is two ways to check whether the model is used by o1
- check if modeName is o1. This is true if used with standalone gptscript.
- Check if
OPENAI_MODEL_NAMEis set. This will be set in Obot to determine the name.
StrongMonkey
requested review from
g-linville,
iwilltry42,
njhale,
sanjay920 and
thedadams
Signed-off-by: Daishan Peng <daishan@acorn.io>
StrongMonkey
force-pushed
the
openai-o1
branch
from
062d703 to
77cb909
Compare
|
I changed the approach and move the logic to openai-model-provider. However, we still need a way to dynamically turn off stream since o1 doesn't support it. So the way to do that is to check In plain gptscript user would be expected to set that when they are using o1 model, as there is no smart way to automatically do this though. |
|
Closing in favor of adding the support from openai-proxy. |
1 participant
Openai O1 model doesn't support stream, and doesn't support setting temperature on chat completion. We have to tweak that in order to support o1 model.
obot-platform/obot#1131