enhance: expose MCP server capabilities #976
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Donnie Adams <donnie@acorn.io>
thedadams
force-pushed
the
expose-mcp-capabilities
branch
from
2280fbe to
8c03261
Compare
thedadams
commented
May 27, 2025
| c.Client.OnNotification(handler) | ||
| } | ||
|
|
||
| func (c *client) Capabilities() mcp.ServerCapabilities { |
Contributor
Author
There was a problem hiding this comment.
This is really the thing we need. The rest is just pass-through so we implement the right interface.
There was a problem hiding this comment.
just curious why isn't the next line something like
return c.Client.Capabilities()
like all the other functions
Contributor
Author
There was a problem hiding this comment.
The Client doesn't have this method. That's the reason we are adding this. We need all the methods the Client has, plus the Capabilities method.
tybalex
approved these changes
May 28, 2025
njhale
approved these changes
May 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.