Bazel 8 Migration - Replace Dagger Extension for K2#208
Open
edwin-grabtaxi wants to merge 1 commit intomigration/bazel_8_main_branchfrom
Open
Bazel 8 Migration - Replace Dagger Extension for K2#208edwin-grabtaxi wants to merge 1 commit intomigration/bazel_8_main_branchfrom
edwin-grabtaxi wants to merge 1 commit intomigration/bazel_8_main_branchfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We upgraded Dagger version from 2.46.1 to 2.59.1 (latest) to support K2 compatibility. In the process, we found errors specifically mentioning that extension function is not supported anymore for
@Bindsand@Provides.Turns out, it's not supported since Dagger 2.48, see the release notes here.
With this PR, we changed all the extension function found on
@Bindsto the normal-style function.