Bazel 8 Migration - Workspace Reordering & Patches Registration#209
Open
edwin-grabtaxi wants to merge 2 commits intomigration/bazel_8_main_branchfrom
Open
Bazel 8 Migration - Workspace Reordering & Patches Registration#209edwin-grabtaxi wants to merge 2 commits intomigration/bazel_8_main_branchfrom
edwin-grabtaxi wants to merge 2 commits intomigration/bazel_8_main_branchfrom
Conversation
edwin-grabtaxi
requested review from
adarsh-grabtaxi,
arnav-grabtaxi,
arunsampathkumar-grabtaxi,
minkuanlim-grabtaxi and
vanminh-grabtaxi
as code owners
edwin-grabtaxi
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Workspace Reordering
As part of Bazel externalization,
android toolsare migrated to rules_android. In order to loadrules_android, it has to callrules_android_prereqs(). Inside thatprereqs, it will call its android_tools that contains some jars, includingall_android_tools_deploy.jarand other jars.With the old WORKSPACE setup, our android_tools will be called via
bazel_common_setup, in which it'll be superseded by therules_android's. The changes is to reorderWORSKPACEso our jars get called first and grab-bazel-common will use our patched tools.Changes:
android_tools()calls there beforerules_android_prereqsget called.rules_androidPatches Registration
BUILD.bzlso it can be visible to repositoriesrules_android's http load inrepositories.bzl