EML Schema Server Integrations#1
Open
gracezhou-tech wants to merge 14 commits intogracezhou-tech:mainfrom
Open
EML Schema Server Integrations#1gracezhou-tech wants to merge 14 commits intogracezhou-tech:mainfrom
gracezhou-tech wants to merge 14 commits intogracezhou-tech:mainfrom
Conversation
`delete_pending` is a user- (or client-) driven status and therefore must be on resource, not archive_resource. It applies implicitly to all archive_resources associated with a resource.
It's a PUT. This is expected. Also, combine folder and filename into path across the board. This simplifies path integrity checks and validation, and parts can in any case be easily inferred by the client. If in future we need to distinguish file and folder resource types, this can be done explicitly with an enum on resource, instead of implicitly based on folder/filename values.
Deleting a package sets the status of the package and its resources to delete_pending. Archived resources are deleted via background archival service; purge of delete_pending packages in background packaging service still needs to be done.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.