Skip to content

adjust Suricata Dockerfile to best practices #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
pisces-period wants to merge 1 commit into
base: master
Choose a base branch
from
Open

adjust Suricata Dockerfile to best practices #27

pisces-period wants to merge 1 commit into from

Conversation

@pisces-period
Copy link

@pisces-period pisces-period commented Apr 28, 2020

  • 'RUN' directives concatenated (every 'RUN' command adds another layer to the image, making it heavier - concatenating creates a single layer whilst still running all the necessary commands)
  • Replacing deprecated 'MAINTAINER' with 'LABEL' - mostly cosmetics
  • Ideally the cointainer shouldn't run as root, so it'd be a good idea to use USER ${>1000} (greater than 1000) command so as to run the container as a non-root user; since I haven't thoroughly tested the rest of the code, I'm not adding it here but leaving it as a suggestion

@pisces-period
adjust Suricata Dockerfile to best practices
1e924cd 
- 'RUN' directives concatenated (every 'RUN' command adds another layer to the image, making it heavier)
- Replacing deprecated 'MAINTAINER' with 'LABEL'
- Ideally the cointainer shouldn't run as root, so it'd be a good idea to use USER ${>1000} (greater than 1000) command so as to run the container as a non-root user; since I haven't thoroughly tested the rest of the code, I'm not adding it here but leaving it as a suggestion
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@pisces-period