Skip to content

Conversation

schmikei
Copy link
Contributor

@schmikei schmikei commented Sep 25, 2025

This PR refactors the influxDB mixin to use more modern libraries (logs-lib/commonlib/g.libsonnet) to generate its panels.

InfluxDB cluster overview:

image image

InfluxDB instance overview
image
image
image

InfluxDB logs
image

@schmikei schmikei changed the title Modernize the InfluxDB mixin to use modern libraries (WIP) Modernize the InfluxDB mixin to use modern libraries Sep 26, 2025
@schmikei schmikei marked this pull request as ready for review September 26, 2025 19:57
@schmikei schmikei requested a review from a team as a code owner September 26, 2025 19:57
Copy link
Member

@Dasomeone Dasomeone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only one comment re usage of instance, otherwise this looks good to me! Thanks as always Keith, appreciate it :)

"uid": "${prometheus_datasource}"
},
"expr": "influxdb_users_total{job=~\"$job\", influxdb_cluster=~\"$influxdb_cluster\"}",
"expr": "influxdb_users_total{job=\"integrations/influxdb\",job=~\"$job\",influxdb_cluster=~\"$influxdb_cluster\",instance=~\"$instance\"}",
Copy link
Member

@Dasomeone Dasomeone Sep 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a note here, we'll probably want to avoid including instance as a filtering selector for the cluster overview panels if they weren't already present?
Specifcally, if memory serves, we deliberately excluded them for overview-type panels where we wanted the picture for the whole cluster

… cluster overview. Also fix some placeholder descriptions
@schmikei schmikei requested a review from Dasomeone October 6, 2025 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants