fix(operator): move authorization RBAC to dedicated cluster_scoped controller#16712
Open
JoaoBraveCoding wants to merge 10 commits intografana:mainfrom
Open
fix(operator): move authorization RBAC to dedicated cluster_scoped controller#16712JoaoBraveCoding wants to merge 10 commits intografana:mainfrom
JoaoBraveCoding wants to merge 10 commits intografana:mainfrom
Conversation
JoaoBraveCoding
force-pushed
the
LOG-6083
branch
from
df10429 to
a92c695
Compare
JoaoBraveCoding
force-pushed
the
LOG-6083
branch
2 times, most recently
from
47351a3 to
f8310e1
Compare
JoaoBraveCoding
force-pushed
the
LOG-6083
branch
from
f8310e1 to
8a0e3a9
Compare
JoaoBraveCoding
force-pushed
the
LOG-6083
branch
from
700c146 to
e858fb4
Compare
JoaoBraveCoding
force-pushed
the
LOG-6083
branch
from
e858fb4 to
0908fd8
Compare
JoaoBraveCoding
requested review from
a team,
periklis and
xperimental
as code owners
xperimental
reviewed
Apr 7, 2025
Collaborator
xperimental
left a comment
xperimental
left a comment
There was a problem hiding this comment.
Just reviewing as a "dry run" (mostly code style), because my network is currently limited.
operator/internal/controller/loki/lokistack_cluster_scoped_controller.go
Outdated
Show resolved
Hide resolved
operator/internal/handlers/lokistack_cluster_scope_resources_delete.go
Outdated
Show resolved
Hide resolved
operator/internal/handlers/lokistack_cluster_scope_resources_delete.go
Outdated
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Depends on both:
Which issue(s) this PR fixes:
https://issues.redhat.com/browse/LOG-6083
Special notes for your reviewer:
Checklist
CONTRIBUTING.mdguide (required)featPRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.docs/sources/setup/upgrade/_index.mddeprecated-config.yamlanddeleted-config.yamlfiles respectively in thetools/deprecated-config-checkerdirectory. Example PR