fix: Use keyword arguments for MetaData.reflect() to avoid SQLAlchemy warning #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… warning Fixed SAWarning that occurred due to positional arguments being misinterpreted as dialect_options in SQLAlchemy 2.0. Changes: - Changed metadata.reflect() call to use explicit keyword arguments - bind=engine instead of positional argument - schema=schema instead of positional argument - views=not args.noviews instead of positional argument - only=tables instead of positional argument This resolves the warning: "Can't validate argument 'dialect_options'; can't locate any SQLAlchemy dialect named 'dialect'" 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
metadata.reflect()call to use explicit keyword arguments instead of positional argumentsProblem
When running sqlacodegen with SQLAlchemy 2.0, the following warning was displayed:
This occurred because positional arguments were being passed to
MetaData.reflect(), which in SQLAlchemy 2.0 expects keyword arguments after the first positional argument (bind).Changes
Changed line 59 in
src/sqlacodegen/cli.py:Before:
After:
Impact
Test plan
🤖 Generated with Claude Code