removed formatter as new ImageData fails in at least Edge, replaced w…#3
Open
cthedot wants to merge 1 commit intografijs:masterfrom
Open
removed formatter as new ImageData fails in at least Edge, replaced w…#3cthedot wants to merge 1 commit intografijs:masterfrom
cthedot wants to merge 1 commit intografijs:masterfrom
Conversation
…ith imgData.data.set(newPixelData). Normalized newPixelData naming.
Author
|
Found solution to failure of new ImageData at SO (where else ;) http://stackoverflow.com/questions/13626465/how-to-create-a-new-imagedata-object-independently Not sure if browsers should allow creating a new ImageData object, guess should check the spec. At least Edge does not allow it and so the former implementation failed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ith imgData.data.set(newPixelData). Normalized newPixelData naming.
Main Change is that lib is working in Edge now (actually in IE11 too, tested on Win10 x64).
The server.js is a basic node based server to be able to test it locally w/o webserver. Not needed really, feel free to omit.
Thanks!