Skip to content

removed formatter as new ImageData fails in at least Edge, replaced w…#3

Open
cthedot wants to merge 1 commit intografijs:masterfrom
cthedot:master
Open

removed formatter as new ImageData fails in at least Edge, replaced w…#3
cthedot wants to merge 1 commit intografijs:masterfrom
cthedot:master

Conversation

@cthedot
Copy link

@cthedot cthedot commented Apr 27, 2016

…ith imgData.data.set(newPixelData). Normalized newPixelData naming.

Main Change is that lib is working in Edge now (actually in IE11 too, tested on Win10 x64).

The server.js is a basic node based server to be able to test it locally w/o webserver. Not needed really, feel free to omit.

Thanks!

…ith imgData.data.set(newPixelData). Normalized newPixelData naming.
@cthedot
Copy link
Author

cthedot commented Apr 27, 2016

Found solution to failure of new ImageData at SO (where else ;) http://stackoverflow.com/questions/13626465/how-to-create-a-new-imagedata-object-independently

Not sure if browsers should allow creating a new ImageData object, guess should check the spec. At least Edge does not allow it and so the former implementation failed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant