Skip to content

fix: Memory.get_segment_byte_offset on Passive data sections #268

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
spotandjake wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: Memory.get_segment_byte_offset on Passive data sections #268

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/memory.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,7 +121,11 @@ caml_binaryen_get_memory_segment_byte_offset(value _module, value _name) {
CAMLparam2(_module, _name);
BinaryenModuleRef module = BinaryenModuleRef_val(_module);
char* name = Safe_String_val(_name);
CAMLreturn(Val_int(BinaryenGetMemorySegmentByteOffset(module, name)));
if (BinaryenGetMemorySegmentPassive(module, name)) {
CAMLreturn(Val_int(-1));
} else {
CAMLreturn(Val_int(BinaryenGetMemorySegmentByteOffset(module, name)));
}
}

CAMLprim value
Expand Down
3 changes: 3 additions & 0 deletions test/test.ml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -248,6 +248,9 @@ let _ = Memory.set_memory max_memory_wasm_mod 1 2 "memory" [] false false "0"
let _ = assert (Memory.has_max max_memory_wasm_mod "0" = true)
let _ = assert (Memory.get_max max_memory_wasm_mod "0" = 2)

(* Memory.get_segment_byte_offset Passive *)
let _ = assert (Memory.get_segment_byte_offset wasm_mod "world" = -1)

let _ =
assert (
Bytes.equal
Expand Down
Loading