Merged
Conversation
KnightNiwrem
approved these changes
Apr 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, it is possible to mutate existing objects in the logs by returning their references from
external, mutating them, and then using checkpoints to rewind the logs and access the mutated objects at a later point.These changes fix that by returning a deep clone of all objects in the logs that are accessed via
external. Note that (persistent) storage adapters have just deserialised the data before giving it back to the plugin at this point. In most cases, this means that it was parsed from JSON. It is therefore safe to clone it.Regular wait calls and API calls are intentionally left unfixed. This is because it is extremely rare for people to mutate the update objects returned from wait calls or API calls. At the same time, those are a large part of the data in the logs. I feat that it would come at a significant runtime cost to always clone the entire log while it is being replayed.
Fixes #137.