Skip to content

fix: call onExit when conversation.halt without conversation.wait#145

Merged
KnorpelSenf merged 2 commits intomainfrom
fix/000-call-onExit-on-halt-without-wait
Aug 17, 2025
Merged

fix: call onExit when conversation.halt without conversation.wait#145
KnorpelSenf merged 2 commits intomainfrom
fix/000-call-onExit-on-halt-without-wait

Conversation

@KnightNiwrem
Copy link
Contributor

No description provided.

Copy link
Member

@KnorpelSenf KnorpelSenf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a test?

@KnightNiwrem
Copy link
Contributor Author

Can you add a test?

Done

Copy link
Member

@KnorpelSenf KnorpelSenf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@KnorpelSenf KnorpelSenf changed the title fix: Call onExit when conversation.halt without conversation.wait fix: call onExit when conversation.halt without conversation.wait Aug 17, 2025
@KnorpelSenf KnorpelSenf merged commit ac9641f into main Aug 17, 2025
6 checks passed
@KnorpelSenf KnorpelSenf deleted the fix/000-call-onExit-on-halt-without-wait branch August 17, 2025 06:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants