Implemented changes to attestations based on LeanSpec commit #234 #37
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
nsannn
commented
Jan 12, 2026
nsannn
commented
- Removed to_plain() method, added check for duplicate data.
- Minor fixes to Cargo.toml to use use env-config/devnet2 in devnet2 feature flags
…dded readme on how to select devnet
…) method, added check for duplicate data
ArtiomTr
requested changes
Jan 14, 2026
| pub fn to_plain(&self) -> Vec<Attestation> { | ||
| let validator_indices = self.aggregation_bits.to_validator_indices(); | ||
| /// Trait for checking duplicate attestation data. | ||
| pub trait HasDuplicateData { |
Collaborator
There was a problem hiding this comment.
Why trait? You can just add new function to impl block above?
Comment on lines
+516
to
+518
| while justified_slots_working.len() <= target_slot_int { | ||
| justified_slots_working.push(false); | ||
| } |
Collaborator
There was a problem hiding this comment.
I believe this can be simplified with .extend(iter::repeat_n(false, target_slot_int.saturating_sub(justified_slots_working.len())))
nsannn
added a commit
that referenced
this pull request
Jan 18, 2026
This was referenced Jan 18, 2026
Collaborator
Author
|
I believe that we can close this PR, since these requested changes have been addressed in latest devnet-2 branch commits. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.