Fix XMSS signature vector tests #62
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ArtiomTr
requested changes
Jan 26, 2026
| .join(spec_file); | ||
|
|
||
| TestRunner::run_verify_signatures_test(test_path).unwrap(); | ||
| TestRunner::run_verify_signatures_test(test_path)?; |
Collaborator
There was a problem hiding this comment.
why? just unwrap error, no need to handle them gracefully
| "tests/consensus/devnet/verify_signatures/test_invalid_signatures.py::test_invalid_signature[fork_Devnet][fork_devnet-verify_signatures_test]": { | ||
| "network": "Devnet", | ||
| "leanEnv": "test", | ||
| "leanEnv": "prod", |
Collaborator
There was a problem hiding this comment.
don't generate tests by hand, update makefile script & use it instead:
.PHONY: generate-test-vectors
generate-test-vectors:
@rm -rf spec && \
mkdir -p spec && \
cd spec && \
git init && \
git remote add origin https://github.com/leanEthereum/leanSpec.git && \
git fetch --depth 1 origin $(LEAN_SPEC_COMMIT) && \
git switch --detach FETCH_HEAD
- cd spec && uv run fill --clean --fork=devnet
+ cd spec && uv run fill --clean --fork=devnet --scheme prod
rm -rf ./test_vectors && mkdir -p ./test_vectors
cp -r ./spec/fixtures/consensus/* ./test_vectors/
Comment on lines
+632
to
+638
| let expect_exception = raw | ||
| .get("tests") | ||
| .and_then(|t| t.as_object()) | ||
| .and_then(|obj| obj.values().next()) | ||
| .and_then(|tc| tc.get("expectException")) | ||
| .and_then(|v| v.as_str()) | ||
| .map(|s| s.to_owned()); |
Collaborator
There was a problem hiding this comment.
don't handle json by hand, just update "VerifySignaturesTestVectorFile" struct
| .map(|s| s.to_owned()); | ||
|
|
||
| // Phase 2: parse into the typed structure. | ||
| let test_file: VerifySignaturesTestVectorFile = match serde_json::from_str(&json_content) { |
Collaborator
There was a problem hiding this comment.
no need to handle json errors - nobody structures invalid json as spec test failure. Spec test must always be parsed, if it is not - then it is test failure, not "expected error".
Collaborator
|
let's merge this now, and do style fixes later |
LiudasBaronas1
pushed a commit
that referenced
this pull request
Jan 27, 2026
Co-authored-by: noopur23 <82257577+noopur23@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After this update, the vector tests run with
cargo test -p containers --features xmss-verify test_vectors::verify_signaturesnow pass