-
Notifications
You must be signed in to change notification settings - Fork 124
feat(cdn): add versioned artifact endpoints #7400
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(cdn): add versioned artifact endpoints #7400
Conversation
This reverts commit 1cd44f6.
Summary of ChangesHello @n1ru4l, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request implements a significant feature by adding support for versioned artifact endpoints to the CDN. This allows consumers to retrieve specific, immutable versions of schema artifacts (SDL, supergraph, services, metadata, and contracts) using a unique version ID. The change involves modifying the artifact storage mechanism to persist both the latest and version-specific copies of artifacts, updating the CDN worker to handle new versioned routes, and ensuring that all responses include a "x-hive-schema-version-id" header for clarity. This enhancement provides greater control and reliability for schema artifact distribution. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
📚 Storybook DeploymentThe latest changes are available as preview in: https://pr-7400.hive-storybook.pages.dev |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces support for retrieving CDN artifacts by schema version ID. New CDN endpoints have been added to fetch schema and contract artifacts for a specific version. During schema publication, artifacts are now written to both a 'latest' path and a new versioned path in S3, ensuring historical versions are retrievable and immutable. The CDN responses for both latest and versioned artifacts now include an x-hive-schema-version-id header. Integration tests were added to cover various scenarios, including successful retrieval of versioned SDL, supergraph, services, metadata, and contract artifacts, handling of non-existent or invalid version IDs, authentication failures, If-None-Match caching, and immutability of versioned artifacts after new schema publishes. Core services were updated to pass the schema version ID during artifact writing and to the actionFn for schema publishing and deletion.
💻 Website PreviewThe latest changes are available as preview in: https://pr-7400.hive-landing-page.pages.dev |
|
🐋 This PR was built and pushed to the following Docker images: Targets: Platforms: Image Tag: |
Reverts #7399