Skip to content

Conversation

@n1ru4l
Copy link
Contributor

@n1ru4l n1ru4l commented Dec 10, 2025

Reverts #7399

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @n1ru4l, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request implements a significant feature by adding support for versioned artifact endpoints to the CDN. This allows consumers to retrieve specific, immutable versions of schema artifacts (SDL, supergraph, services, metadata, and contracts) using a unique version ID. The change involves modifying the artifact storage mechanism to persist both the latest and version-specific copies of artifacts, updating the CDN worker to handle new versioned routes, and ensuring that all responses include a "x-hive-schema-version-id" header for clarity. This enhancement provides greater control and reliability for schema artifact distribution.

Highlights

  • Versioned CDN Endpoints: Introduced new CDN endpoints to fetch schema artifacts by a specific version ID.
  • Dual Artifact Storage: Schema artifacts are now written to both a "latest" path and a "versioned" path during schema publish, enabling retrieval of historical versions.
  • Schema Version ID Header: CDN artifact responses now include the "x-hive-schema-version-id" header, providing the version ID of the served schema.
  • Immutability of Versioned Artifacts: Versioned artifacts are aggressively cached and remain immutable even after new schema publishes.
  • Comprehensive Testing: New integration tests cover various scenarios for versioned artifact access, including authentication, error handling, and contract artifacts.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 10, 2025

🚀 Snapshot Release (alpha)

The latest changes of this PR are available as alpha on npm (based on the declared changesets):

Package Version Info
hive 8.13.0-alpha-20251210114419-a63ffe64b639695df6fb22739ad72510dfc73f95 npm ↗︎ unpkg ↗︎

@github-actions
Copy link
Contributor

github-actions bot commented Dec 10, 2025

📚 Storybook Deployment

The latest changes are available as preview in: https://pr-7400.hive-storybook.pages.dev

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces support for retrieving CDN artifacts by schema version ID. New CDN endpoints have been added to fetch schema and contract artifacts for a specific version. During schema publication, artifacts are now written to both a 'latest' path and a new versioned path in S3, ensuring historical versions are retrievable and immutable. The CDN responses for both latest and versioned artifacts now include an x-hive-schema-version-id header. Integration tests were added to cover various scenarios, including successful retrieval of versioned SDL, supergraph, services, metadata, and contract artifacts, handling of non-existent or invalid version IDs, authentication failures, If-None-Match caching, and immutability of versioned artifacts after new schema publishes. Core services were updated to pass the schema version ID during artifact writing and to the actionFn for schema publishing and deletion.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 10, 2025

💻 Website Preview

The latest changes are available as preview in: https://pr-7400.hive-landing-page.pages.dev

@github-actions
Copy link
Contributor

github-actions bot commented Dec 10, 2025

🐋 This PR was built and pushed to the following Docker images:

Targets: build

Platforms: linux/amd64

Image Tag: a63ffe64b639695df6fb22739ad72510dfc73f95

@theguild-bot theguild-bot temporarily deployed to staging December 10, 2025 11:14 Inactive
@n1ru4l n1ru4l merged commit c396566 into main Dec 10, 2025
27 checks passed
@n1ru4l n1ru4l deleted the revert-7399-revert-7348-adam/cdn-versioned-schema branch December 10, 2025 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants