Skip to content

Conversation

dotansimha
Copy link
Member

@dotansimha dotansimha commented Sep 3, 2025

Closes #439

  • fetch supergraph from CDN
  • config to fetch
  • TLS fix
  • polling interval
  • swaping of supergraph state
  • etag support
  • error handling
  • ? supergraph checksum

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Hello @dotansimha, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly enhances the router's operational flexibility by introducing new capabilities for supergraph schema management and secure subgraph communication. It allows the router to dynamically fetch its supergraph configuration from a centralized Hive Console CDN and ensures that all interactions with subgraphs are conducted over secure HTTPS connections, improving both deployment options and data integrity.

Highlights

  • New Supergraph Source: Hive Console CDN: The router now supports fetching the supergraph schema directly from the Hive Console CDN. This introduces a new hive source type in the configuration, requiring an endpoint and an API key.
  • Enhanced HTTPS Connectivity for Subgraphs: The subgraph executors have been upgraded to utilize an HTTPS connector, improving secure communication with backend services. This change specifically integrates hyper-tls for robust TLS support in HTTP client operations.
  • Refactored Supergraph Loading Logic: The internal mechanism for loading supergraph definitions has been significantly refactored. A new SupergraphLoader trait and its implementations (SupergraphFileLoader, SupergraphHiveConsoleLoader) centralize and abstract the process of retrieving the supergraph schema, making it more flexible and extensible.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces two main features: the ability to load the supergraph from a Hive CDN endpoint, and support for HTTPS connectors when communicating with subgraphs. The changes are well-structured, introducing a new supergraph module to handle different loading strategies. The implementation for HTTPS support in the executor is also correct. I have a couple of suggestions to improve robustness and error handling.

@dotansimha dotansimha mentioned this pull request Sep 3, 2025
Copy link

github-actions bot commented Sep 3, 2025

k6-benchmark results

     ✓ response code was 200
     ✓ no graphql errors
     ✓ valid response structure

     █ setup

     checks.........................: 100.00% ✓ 236823      ✗ 0    
     data_received..................: 6.9 GB  230 MB/s
     data_sent......................: 93 MB   3.1 MB/s
     http_req_blocked...............: avg=3.15µs   min=691ns   med=1.74µs  max=19.85ms  p(90)=2.45µs  p(95)=2.83µs  
     http_req_connecting............: avg=204ns    min=0s      med=0s      max=868.55µs p(90)=0s      p(95)=0s      
     http_req_duration..............: avg=18.58ms  min=1.79ms  med=17.62ms max=229.81ms p(90)=25.67ms p(95)=28.72ms 
       { expected_response:true }...: avg=18.58ms  min=1.79ms  med=17.62ms max=229.81ms p(90)=25.67ms p(95)=28.72ms 
     http_req_failed................: 0.00%   ✓ 0           ✗ 78961
     http_req_receiving.............: avg=146.66µs min=24.92µs med=38.66µs max=203.67ms p(90)=86.02µs p(95)=366.83µs
     http_req_sending...............: avg=23.7µs   min=5.29µs  med=10.42µs max=23.09ms  p(90)=15.72µs p(95)=27.41µs 
     http_req_tls_handshaking.......: avg=0s       min=0s      med=0s      max=0s       p(90)=0s      p(95)=0s      
     http_req_waiting...............: avg=18.41ms  min=1.75ms  med=17.5ms  max=112.1ms  p(90)=25.43ms p(95)=28.43ms 
     http_reqs......................: 78961   2627.100821/s
     iteration_duration.............: avg=18.99ms  min=5.34ms  med=17.99ms max=257.1ms  p(90)=26.14ms p(95)=29.22ms 
     iterations.....................: 78941   2626.435404/s
     vus............................: 50      min=50        max=50 
     vus_max........................: 50      min=50        max=50 

@dotansimha dotansimha force-pushed the wip-hive-source branch 2 times, most recently from abcf925 to 49564eb Compare September 4, 2025 07:50
Copy link

github-actions bot commented Sep 4, 2025

🐋 This PR was built and pushed to the following Docker images:

Image Names: ghcr.io/graphql-hive/router

Platforms: linux/amd64,linux/arm64

Image Tags: ghcr.io/graphql-hive/router:pr-400 ghcr.io/graphql-hive/router:sha-3cbf81d

Docker metadata
{
"buildx.build.ref": "builder-32479888-7b63-4a8f-8010-4ebe3b00178d/builder-32479888-7b63-4a8f-8010-4ebe3b00178d0/jti8e6zwnul6cdk3x875sbliy",
"containerimage.descriptor": {
  "mediaType": "application/vnd.oci.image.index.v1+json",
  "digest": "sha256:b1f646a127f2a0b222710dfb5318ff96a3d143b5ca721834dcabeeedf54bcfc7",
  "size": 1609
},
"containerimage.digest": "sha256:b1f646a127f2a0b222710dfb5318ff96a3d143b5ca721834dcabeeedf54bcfc7",
"image.name": "ghcr.io/graphql-hive/router:pr-400,ghcr.io/graphql-hive/router:sha-3cbf81d"
}

@dotansimha dotansimha changed the title feat(router): support hive as source for supergraph, https connector feat(router): support hive as source for supergraph Sep 7, 2025
@dotansimha dotansimha marked this pull request as draft September 21, 2025 10:26
feat(config): improve file-loading for supergraph
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hive Router + CDN usage
1 participant