-
Notifications
You must be signed in to change notification settings - Fork 0
feat(router): support hive
as source for supergraph
#400
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of Changes
Hello @dotansimha, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request significantly enhances the router's operational flexibility by introducing new capabilities for supergraph schema management and secure subgraph communication. It allows the router to dynamically fetch its supergraph configuration from a centralized Hive Console CDN and ensures that all interactions with subgraphs are conducted over secure HTTPS connections, improving both deployment options and data integrity.
Highlights
- New Supergraph Source: Hive Console CDN: The router now supports fetching the supergraph schema directly from the Hive Console CDN. This introduces a new
hive
source type in the configuration, requiring an endpoint and an API key. - Enhanced HTTPS Connectivity for Subgraphs: The subgraph executors have been upgraded to utilize an HTTPS connector, improving secure communication with backend services. This change specifically integrates
hyper-tls
for robust TLS support in HTTP client operations. - Refactored Supergraph Loading Logic: The internal mechanism for loading supergraph definitions has been significantly refactored. A new
SupergraphLoader
trait and its implementations (SupergraphFileLoader
,SupergraphHiveConsoleLoader
) centralize and abstract the process of retrieving the supergraph schema, making it more flexible and extensible.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command>
or @gemini-code-assist <command>
. Below is a summary of the supported commands.
Feature | Command | Description |
---|---|---|
Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/
folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
c74bfdb
to
01c03b3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces two main features: the ability to load the supergraph from a Hive CDN endpoint, and support for HTTPS connectors when communicating with subgraphs. The changes are well-structured, introducing a new supergraph
module to handle different loading strategies. The implementation for HTTPS support in the executor is also correct. I have a couple of suggestions to improve robustness and error handling.
✅
|
abcf925
to
49564eb
Compare
🐋 This PR was built and pushed to the following Docker images: Image Names: Platforms: Image Tags: Docker metadata{
"buildx.build.ref": "builder-32479888-7b63-4a8f-8010-4ebe3b00178d/builder-32479888-7b63-4a8f-8010-4ebe3b00178d0/jti8e6zwnul6cdk3x875sbliy",
"containerimage.descriptor": {
"mediaType": "application/vnd.oci.image.index.v1+json",
"digest": "sha256:b1f646a127f2a0b222710dfb5318ff96a3d143b5ca721834dcabeeedf54bcfc7",
"size": 1609
},
"containerimage.digest": "sha256:b1f646a127f2a0b222710dfb5318ff96a3d143b5ca721834dcabeeedf54bcfc7",
"image.name": "ghcr.io/graphql-hive/router:pr-400,ghcr.io/graphql-hive/router:sha-3cbf81d"
} |
hive
as source for supergraph, https
connectorhive
as source for supergraph
feat(config): improve file-loading for supergraph
49564eb
to
3db3b69
Compare
Closes #439
etag
support