introduce concept of DispatchStrategy #243
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bbakerman
reviewed
Oct 26, 2025
| import org.jspecify.annotations.NullMarked; | ||
|
|
||
| @NullMarked | ||
| @PublicApi |
There was a problem hiding this comment.
Is an SPI right? We would expect people to implement it?
bbakerman
reviewed
Oct 26, 2025
| CompletableFuture<V> result = loadImpl(key, keyContext); | ||
| options.getDispatchStrategy().loadCalled(this); | ||
| return result; | ||
| } |
There was a problem hiding this comment.
I feel like this should be in DataLoaderHelper which is really the guts of the code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is port of the concept of a dispatch strategy from GraphQL Java to DataLoader itself.
It allows DataLoader to be used with an automatic dispatch strategy.
One DispatchStrategy which is based on the concept of being busy or not, is provided.