Skip to content

NM-176: update upgrade links to netmaker CDN #1161

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
abhishek9686 wants to merge 2 commits into
base: develop
Choose a base branch
from
Draft

NM-176: update upgrade links to netmaker CDN #1161

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
097d987
update upgrade links to netmaker CDN
abhishek9686 Dec 1, 2025
5d5ec24
NM-176: add info log to view upgrade details
abhishek9686 Dec 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions functions/use_version.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ import (
"github.com/gravitl/netclient/daemon"
"github.com/gravitl/netclient/ncutils"
"github.com/minio/selfupdate"
"golang.org/x/exp/slog"
)

var binPath, filePath string
Expand All @@ -30,7 +31,7 @@ func createDirIfNotExists() error {
}

func downloadVersion(version string) error {
url := fmt.Sprintf("https://github.com/gravitl/netclient/releases/download/%s/netclient-%s-%s", version, runtime.GOOS, runtime.GOARCH)
url := fmt.Sprintf("https://downloads.netmaker.io/releases/download/%s/netclient-%s-%s", version, runtime.GOOS, runtime.GOARCH)
if runtime.GOOS == "freebsd" {
out, err := ncutils.RunCmd("grep VERSION_ID /etc/os-release", false)
if err != nil {
Expand All @@ -45,7 +46,7 @@ func downloadVersion(version string) error {
return fmt.Errorf("get freebsd vesion %v", freebsdVersion)
}
freebsd := strings.Trim(freebsdVersion[0], "\"")
url = fmt.Sprintf("https://github.com/gravitl/netclient/releases/download/%s/netclient-%s%s-%s", version, runtime.GOOS, freebsd, runtime.GOARCH)
url = fmt.Sprintf("https://downloads.netmaker.io/releases/download/%s/netclient-%s%s-%s", version, runtime.GOOS, freebsd, runtime.GOARCH)
}
if runtime.GOARCH == "arm" && runtime.GOOS == "linux" {
out, err := ncutils.RunCmd("cat /proc/cpuinfo | grep architecture | head -1 | grep -o -E '[0-9]+'", false)
Expand All @@ -57,8 +58,9 @@ func downloadVersion(version string) error {
} else if strings.Contains(out, "\n") {
out = strings.ReplaceAll(out, "\n", "")
}
url = fmt.Sprintf("https://github.com/gravitl/netclient/releases/download/%s/netclient-%s-%sv%s", version, runtime.GOOS, runtime.GOARCH, strings.TrimSpace(out))
url = fmt.Sprintf("https://downloads.netmaker.io/releases/download/%s/netclient-%s-%sv%s", version, runtime.GOOS, runtime.GOARCH, strings.TrimSpace(out))
}
slog.Info("Upgrading netclient", "Curr version", config.Netclient().Version, "New version", version, "pulling from", url)
res, err := http.Get(url)
if err != nil {
return err
Expand Down Expand Up @@ -114,7 +116,8 @@ func versionLessThan(v1, v2 string) (bool, error) {
func UseVersion(version string, rebootDaemon bool) error {
// Use Windows specific version change process
if runtime.GOOS == "windows" {
windowsBinaryURL := fmt.Sprintf("https://github.com/gravitl/netclient/releases/download/%s/netclient-%s-%s.exe", version, runtime.GOOS, runtime.GOARCH)
windowsBinaryURL := fmt.Sprintf("https://downloads.netmaker.io/download/%s/netclient-%s-%s.exe", version, runtime.GOOS, runtime.GOARCH)
slog.Info("Upgrading netclient", "Curr version", config.Netclient().Version, "New version", version, "pulling from", windowsBinaryURL)
if err := windowsUpdate(windowsBinaryURL); err != nil {
return err
}
Expand Down