Skip to content

NM-283: fix missing endpoint-ip6 flag name and restrict MTU flag to push cmd#1268

Open
abhishek9686 wants to merge 6 commits intodevelopfrom
NM-283
Open

NM-283: fix missing endpoint-ip6 flag name and restrict MTU flag to push cmd#1268
abhishek9686 wants to merge 6 commits intodevelopfrom
NM-283

Conversation

@abhishek9686
Copy link
Member

@abhishek9686 abhishek9686 commented Mar 19, 2026

The EndpointIP6 field was not initialized in registerFlags, causing the --endpoint-ip6 / -E flag to render as an unnamed flag. Also remove the MTU flag from join and register commands since MTU should only be changed via push after the host is already enrolled.

Describe your changes

Provide Issue ticket number if applicable/not in title

Provide link to Netmaker PR if required

Provide testing steps

Checklist before requesting a review

  • My changes affect only 10 files or less.
  • I have performed a self-review of my code and tested it.
  • If it is a new feature, I have added thorough tests, my code is <= 1450 lines.
  • If it is a bugfix, my code is <= 200 lines.
  • My functions are <= 80 lines.
  • I have had my code reviewed by a peer.
  • My unit tests pass locally.
  • Netclient & Netmaker are awesome.

…ush command

The EndpointIP6 field was not initialized in registerFlags, causing the
--endpoint-ip6 / -E flag to render as an unnamed flag. Also remove the
MTU flag from join and register commands since MTU should only be
changed via push after the host is already enrolled.
@tenki-reviewer
Copy link

tenki-reviewer bot commented Mar 19, 2026

Tenki Code Review - Complete

Files Reviewed: 2
Findings: 0


This PR cleans up flag registration by removing the --mtu flag from join/register commands and adding a missing EndpointIP6 struct field initializer. One inconsistency was found: push exposes EndpointIP but not EndpointIP6, leaving IPv6 endpoint updates inaccessible from that command.

Files Reviewed (2 files)
cmd/join.go
cmd/register.go

@abhishek9686 abhishek9686 changed the title NM-283: fix missing endpoint-ip6 flag name and restrict MTU flag to p… NM-283: fix missing endpoint-ip6 flag name and restrict MTU flag to push cmd Mar 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants