NM-283: fix missing endpoint-ip6 flag name and restrict MTU flag to push cmd#1268
Open
abhishek9686 wants to merge 6 commits intodevelopfrom
Open
NM-283: fix missing endpoint-ip6 flag name and restrict MTU flag to push cmd#1268abhishek9686 wants to merge 6 commits intodevelopfrom
abhishek9686 wants to merge 6 commits intodevelopfrom
Conversation
…ush command The EndpointIP6 field was not initialized in registerFlags, causing the --endpoint-ip6 / -E flag to render as an unnamed flag. Also remove the MTU flag from join and register commands since MTU should only be changed via push after the host is already enrolled.
|
Tenki Code Review - Complete Files Reviewed: 2 This PR cleans up flag registration by removing the Files Reviewed (2 files) |
NEETweeb
approved these changes
Mar 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The EndpointIP6 field was not initialized in registerFlags, causing the --endpoint-ip6 / -E flag to render as an unnamed flag. Also remove the MTU flag from join and register commands since MTU should only be changed via push after the host is already enrolled.
Describe your changes
Provide Issue ticket number if applicable/not in title
Provide link to Netmaker PR if required
Provide testing steps
Checklist before requesting a review