fix(Button): avoid icon shrink #2563
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amje
approved these changes
Jan 28, 2026
Contributor
|
Preview is ready. |
ogonkov
commented
Jan 28, 2026
Contributor
Author
There was a problem hiding this comment.
In Playwright report text is moved to a half of pixel in the last button
Contributor
|
🎭 Component Tests Report is ready. |
amje
requested changes
Jan 28, 2026
| }; | ||
|
|
||
| /** Story for testing icon shrink with text overflow */ | ||
| export const TestIconTextOverflow: Story = { |
Contributor
There was a problem hiding this comment.
Let's not use stories for testing purposes. Instead, provide this layout directly in the test
| <Button {...args}> | ||
| <IconWithSize data={Heart} size={args.size} /> | ||
| { | ||
| 'AwacsEasyUpstream "cdp-api.metrika.foobar.net-cdp-api-heavy-upstream-retriable": DEPLOYING: AwacsUpstream "metrika-java/cdp-api.metrika.foobar.net-cdp-api-heavy-upstream-retriable" is still in progress: metrika-java/cdp-api.metrika.foobar.net-cdp-api-heavy-upstream-retriable is still in progress' |
Contributor
There was a problem hiding this comment.
Please use more reasonable text, lorem part would be ok
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.