Skip to content

feat(design)!: update breadcrumb component to support truncation#3569

Closed
xelaint wants to merge 3 commits intodevelopfrom
breadcrumb-truncate
Closed

feat(design)!: update breadcrumb component to support truncation#3569
xelaint wants to merge 3 commits intodevelopfrom
breadcrumb-truncate

Conversation

@xelaint
Copy link
Member

@xelaint xelaint commented Mar 19, 2025

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Fixes: #3513

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[ ] No

Other information

@xelaint
Copy link
Member Author

xelaint commented Mar 20, 2025

via css:

  • hide 2nd to second to last items on mobile

Proposed new usage:

<nav>
	<daff-breadcrumb>
		<a daffBreadcrumbItem [link]="">Breadcrumb Label</a>
	</daff-breadcrumb>
</nav>

Last breadcrumb item should not be clickable/linked. Last breadcrumb item should have the class active added to it.

@xelaint xelaint changed the title add menu to breadcrumb feat(design)!: update breadcrumb component to support truncation Mar 21, 2025
@xelaint xelaint added package: design @daffodil/design status: wip This PR is WIP. It should be marked as a draft. labels Mar 21, 2025
@xelaint xelaint force-pushed the breadcrumb-truncate branch from 74e7476 to 2ff15ba Compare September 19, 2025 13:12
@xelaint
Copy link
Member Author

xelaint commented Sep 19, 2025

Screen Shot 2025-09-19 at 9 17 36 AM Screen Shot 2025-09-19 at 9 14 07 AM

The UI in the PR is complete, but there is still some buggy behavior that needs to be looked at. (e.g. the ellipsis to activate menu does not always work)

@joannalauu
Copy link
Contributor

joannalauu commented Jan 6, 2026

@xelaint @damienwebdev Hey, I've resolved the bug where the ellipses to open the menu doesn't always work, as well as the issue where the item at index 2 is not in the partial menu. May I ask if there were any additional errors that were identified when this draft PR was created?

@xelaint
Copy link
Member Author

xelaint commented Jan 8, 2026

Closed in favor of #4278

@xelaint xelaint closed this Jan 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs contributor package: design @daffodil/design status: wip This PR is WIP. It should be marked as a draft.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[FEAT] Add truncated design and support for injecting the DaffMenuModule to DaffBreadcrumbComponent

3 participants