forked from auberonedu/ramblebot
-
Notifications
You must be signed in to change notification settings - Fork 27
Reetan Singh #22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
reetansingh
wants to merge
9
commits into
grc-cohort-21:main
Choose a base branch
from
reetansingh:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Reetan Singh #22
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
b6e861a
Commit message
e5e114d
test
8103039
tokens are read with the scanner and added to our list
dbd5425
test checks the whitespace for extra white space and makes sure final…
a8798df
should send token to lower case
e4d9f2f
checks our token to see if it ends with a .
ed577c9
if token does end with a period its removed
f2dedd7
if token dosent end with . add
f2a6145
debugging fixing missing brackets
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Binary file not shown.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -15,10 +15,19 @@ void testTokenizeWithNoCapitalizationOrPeriod() { | |
| assertEquals(List.of("this", "is", "a", "lowercase", "sentence", "without", "a", "period"), tokens); | ||
| } | ||
|
|
||
| // Wave 2 | ||
| /* | ||
| * Write your test here! | ||
| */ | ||
| // Wave 2 | ||
| @Test | ||
| void testTokenizeWithManySpaces() { | ||
| LowercaseSentenceTokenizer tokenizer = new LowercaseSentenceTokenizer(); | ||
| String input = "hello hi hi hi hello hello"; | ||
| Scanner scanner = new Scanner(input); | ||
|
|
||
| List<String> tokens = tokenizer.tokenize(scanner); | ||
| List<String> expected = List.of("hello", "hi", "hi", "hi", "hello", "hello"); | ||
|
|
||
| assertEquals(expected, tokens, "Tokens did not match "); | ||
| } | ||
|
Comment on lines
+19
to
+29
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Nice test! |
||
|
|
||
|
|
||
|
|
||
| // Wave 3 | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great logic!