Open
Conversation
auberonedu
reviewed
Jan 10, 2025
Comment on lines
+80
to
+82
| // You didn't say if you wanted it sorted by keys or by value | ||
| // TreeMap keys are automatically sorted, so we can put the HashMap in a TreeMap to sort by keys | ||
| TreeMap<String, Integer> sortedTallyMap = new TreeMap<>(tallyMap); |
There was a problem hiding this comment.
The README says "The order is unimportant", but I like that you're considering this!
Comment on lines
+116
to
+118
| With a little more work I think I could add a piece so we weren't re-checking IDs that we already know are invalid | ||
| */ | ||
| int numberEntries = Collections.frequency(ids, ids.get(i)); |
There was a problem hiding this comment.
Very cool! I agree, there are ways to do this a bit more efficiently, but this is a really nice concise readable way of doing it. If we know our input is going to be relatively small and speed is unimportant, this is a great approach.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.