Open
Conversation
auberonedu
reviewed
Jan 13, 2025
auberonedu
left a comment
auberonedu
left a comment
There was a problem hiding this comment.
Nice job with wave 1! I think the algorithm you have for wave 2 doesn't quite work though, see comments below.
Comment on lines
56
to
+69
| // TODO: Implement this method | ||
| Map<String, Integer> count = new HashMap<>(); | ||
| for(String item: topics) | ||
| { | ||
| if(!count.containsKey(item)) | ||
| { | ||
| count.put(item, 1); | ||
| } | ||
| else | ||
| { | ||
| int currentCount = count.get(item); | ||
| int newCount = currentCount + 1; | ||
| count.put(item, newCount); | ||
| } |
Comment on lines
+91
to
+103
| Map<String, Integer> count = new HashMap<>(); | ||
| for(String item: topics) | ||
| { | ||
| if(!count.containsKey(item)) | ||
| { | ||
| count.put(item, 1); | ||
| } | ||
| else | ||
| { | ||
| int currentCount = count.remove(item); | ||
| count.put(item, currentCount); | ||
| } | ||
| } |
There was a problem hiding this comment.
I don't think this algorithm quite works. As described in the README, the expected output for the sample file is
{maps=1, loops=1, arrays=2}
but yours actually gives
{maps=1, lists=1, loops=1, arrays=1, compound=1}
Make sure to always check your code to see whether it's giving the result you expect.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.