Open
Conversation
auberonedu
reviewed
Jan 13, 2025
auberonedu
left a comment
auberonedu
left a comment
There was a problem hiding this comment.
Nice job! I like seeing both your approaches through your commit history.
We'll be talking more about complexity analysis later, but this is a great place where you can start applying it now. If you remember Big O analysis, can you start considering which of your approaches would have the better time complexity? No need to respond or change anything here, just something to start thinking about!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are two versions:
[Tallyer works, does not use List for wave 2.] - This uses a frequency method which ignores making a map and instead just counts how many times an ID shows up.
[changed to work with Vote List instead of frequency] - I figured a point to this assignment was to use Lists to check how many times ID shows up, so I reworked it to work with an ID