Skip to content

All done#14

Open
samkosal wants to merge 7 commits intogrc-cohort-22:mainfrom
samkosal:main
Open

All done#14
samkosal wants to merge 7 commits intogrc-cohort-22:mainfrom
samkosal:main

Conversation

@samkosal
Copy link
Copy Markdown

@samkosal samkosal commented Oct 2, 2025

No description provided.

Copy link
Copy Markdown

@auberonedu auberonedu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job! You don't need to say "commit" at the end of your commit messages. You could write something like "Finished ArrayPractice exercises"

Comment thread src/ListPractice.java

public static void main(String[] args) {
// Create an empty ArrayList of Strings and assign it to a variable of type List
List<String> ArrayList = new ArrayList<>();
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I recommend not naming variables the exact same name as classes. Our local variables should be camelCase (note that it starts with a lowercase letter). Naming a variable ArrayList (with a capital A) when there is already an ArrayList class is confusing and can lead to problems.

Comment thread src/SetPractice.java
public class SetPractice {
public static void main(String[] args) {
// Create a HashSet of Strings and assign it to a variable of type Set
HashSet<String> Strings = new HashSet<>();
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here and elsewhere, use interface types (List, Map, etc.) where appropriate.
For example:
List<String> strings = new ArrayList<>();
Note that the type on the left is List, not ArrayList. When we do this, we're more flexible to be able to change our code to use a different type of list later.

Similarly for maps:
Map<String, String> myMap = new HashMap<>();
Note that on the left we use Map instead of HashMap.

In summary:

  • interface type on left to declare type (List, Map, etc.)
  • Concrete type on right to instantiate instance (HashMap, ArrayList etc.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants