forked from auberonedu/derusting
-
Notifications
You must be signed in to change notification settings - Fork 25
derusting completion #2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
DarienArthur-Gocken
wants to merge
27
commits into
grc-cohort-22:main
Choose a base branch
from
DarienArthur-Gocken:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
27 commits
Select commit
Hold shift + click to select a range
65a6427
negative float
DarienArthur-Gocken 1c97eb2
positive int
DarienArthur-Gocken ccbf171
modulo remainder
DarienArthur-Gocken 7306a78
Even/Odd numbers.
DarienArthur-Gocken 4a00923
Dividing ints
DarienArthur-Gocken 9ffe1cd
Make arraylist
DarienArthur-Gocken 636ebda
adding elements to list
DarienArthur-Gocken 8f1efd3
setting at specific indexes
DarienArthur-Gocken b644faf
Check for specific string
DarienArthur-Gocken 8e0d8ce
Iterate over list
DarienArthur-Gocken 6bbf327
sort & iterate foreach
DarienArthur-Gocken cbdad62
make new strings array
DarienArthur-Gocken da85422
string values set and checked.
DarienArthur-Gocken 5a6f52c
print array length
DarienArthur-Gocken ca720b5
iterate array loops
DarienArthur-Gocken 3ca8cc6
string init & length
DarienArthur-Gocken 6ed3c5d
concat strings & find value of char
DarienArthur-Gocken ecfc8db
check contains, check each char in string, new arraylist
DarienArthur-Gocken fe71163
adding to array, tostring, checking equals.
DarienArthur-Gocken 61bbd15
init hashset, add elements
DarienArthur-Gocken a485bb2
hashset contains, remove, size
DarienArthur-Gocken edc69f4
iterate over set
DarienArthur-Gocken fb033e8
init hashmap and fill
DarienArthur-Gocken 2b271d5
get value, size, replace, and check contains
DarienArthur-Gocken b59de3f
iterating over hashmap
DarienArthur-Gocken c44bd3b
Person class impl
DarienArthur-Gocken 087de3e
main impl
DarienArthur-Gocken File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here and elsewhere, use interface types (List, Map, etc.) where appropriate.
For example:
List<String> strings = new ArrayList<>();Note that the type on the left is
List, notArrayList. When we do this, we're more flexible to be able to change our code to use a different type of list later.Similarly for maps:
Map<String, String> myMap = new HashMap<>();Note that on the left we use
Mapinstead ofHashMap.In summary: