Open
Conversation
auberonedu
reviewed
Apr 9, 2026
auberonedu
left a comment
auberonedu
left a comment
There was a problem hiding this comment.
Nice work! I'll give credit this time, but please in the future make sure to be making more frequent commits (for something like this at least one per method) to get credit. Also, please see the comment below.
Comment on lines
+41
to
+46
| String output = "pneumonoultramicroscopicsilicovolcanoconiosis"; | ||
| for (String x : words) { | ||
| if (x.length() < output.length() || (x.length() == output.length() && x.compareTo(output) < 0)) { | ||
| output = x; | ||
| } | ||
| } |
There was a problem hiding this comment.
What would happen if our shortest word was "bababadalgharaghtakamminarronnkonnbronntonnerronntuonnthunntrovarrhounawnskawntoohoohoordenenthurnuk" (the first 100-letter-long thunderword in the modernist classic "Finnegans Wake")? Can you think of how you could change your code to be more robust?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.