Implemented all methods in Practice.java#8
Open
jmakho01 wants to merge 10 commits intogrc-cohort-22:mainfrom
Open
Implemented all methods in Practice.java#8jmakho01 wants to merge 10 commits intogrc-cohort-22:mainfrom
jmakho01 wants to merge 10 commits intogrc-cohort-22:mainfrom
Conversation
auberonedu
reviewed
Apr 9, 2026
auberonedu
left a comment
auberonedu
left a comment
There was a problem hiding this comment.
Nice work, but can you think of how to make your code more robust to the below cases?
Comment on lines
+39
to
+40
| int wordLength = 99; | ||
| String shortest = ""; |
There was a problem hiding this comment.
What would happen if our shortest word was "bababadalgharaghtakamminarronnkonnbronntonnerronntuonnthunntrovarrhounawnskawntoohoohoordenenthurnuk" (the first 100-letter-long thunderword in the modernist classic "Finnegans Wake")? Can you think of how you could change your code to be more robust?
Comment on lines
+81
to
+83
| int biggest = -99; | ||
| ListNode<Integer> current = head; | ||
| while(current != null) { |
There was a problem hiding this comment.
Similarly, what if our biggest number was -525600?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Completed all methods, all unit tests pass for each method.