Fix EventFilter tag matching logic#125
Merged
greenart7c3 merged 1 commit intomasterfrom May 4, 2026
Merged
Conversation
Live subscription matching used `tags.none { testTag(...) }`, which
accepts an event when any single tag-key filter passes. NIP-01 requires
all tag-key filters to match (AND across keys, OR within values), the
same semantics already implemented in EventRepository's SQL via
per-tag `EXISTS` clauses joined with `AND`.
https://claude.ai/code/session_011VV7JUFCP3ujUA681Sdi2V
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixed the tag matching logic in EventFilter to correctly validate that all tags match the event, rather than incorrectly rejecting events when any tag matches.
Key Changes
tags.none { testTag(it, event) }to!tags.all { testTag(it, event) }!all(condition)correctly replacesnone(condition)for this use caseImplementation Details
The original logic would reject an event if none of its tags passed the test. The corrected logic now properly rejects an event only if not all of its tags pass the test, which aligns with the expected filter behavior where all specified tags should match for an event to pass the filter.
https://claude.ai/code/session_011VV7JUFCP3ujUA681Sdi2V