Update contingency list by filter form UI #769
+305
−191
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ency list form - Introduced `EquipmentTypesByFilters` for enhanced substation and VL filter handling. - Refactored `ContingencyListFilterBasedForm` to use `PanelGroup` for resizable panels. - Updated default sizes based on filter inclusion. - Enhanced layout and responsiveness. - Extended dependency list with `react-resizable-panels`. Signed-off-by: Florent MILLOT <75525996+flomillot@users.noreply.github.com>
The custom AG Grid cell renderers have been moved from the application-specific folder to the shared @gridsuite/commons-ui library. Updated all references across the codebase to use the shared cell renderers, simplifying code reuse and improving modularity. Signed-off-by: Florent MILLOT <75525996+flomillot@users.noreply.github.com>
…ponents - Replaced `Grid item` titles with heading elements (`h3`, `h4`) for better semantic structure. - Adjusted typography properties to enhance visual clarity and consistency. - Refactored padding and margins in visualization panel for improved responsiveness. Signed-off-by: Florent MILLOT <75525996+flomillot@users.noreply.github.com>
Signed-off-by: Florent MILLOT <75525996+flomillot@users.noreply.github.com>
thangqp
reviewed
Nov 26, 2025
| setIsDataOutdated: (value: boolean) => void; | ||
| } | ||
|
|
||
| export function EquipmentTypesByFilters({ |
Contributor
There was a problem hiding this comment.
Suggested change
| export function EquipmentTypesByFilters({ | |
| function EquipmentTypesByFilters({ |
use export default at the bottom
thangqp
reviewed
Nov 26, 2025
| import { ContingencyFieldConstants, FilterElement, FilterSubEquipments } from '../../../../utils/contingency-list.type'; | ||
| import { FilterBasedContingencyListVisualizationPanel } from './filter-based-contingency-list-visualization-panel'; | ||
| import { isSubstationOrVoltageLevelFilter } from '../contingency-list-utils'; | ||
| import { EquipmentTypesByFilters } from './equipment-types-by-filters'; |
Contributor
There was a problem hiding this comment.
Suggested change
| import { EquipmentTypesByFilters } from './equipment-types-by-filters'; | |
| import EquipmentTypesByFilters from './equipment-types-by-filters'; |
use import default
Contributor
Author
There was a problem hiding this comment.
no I cant there is an eslint error
Ok works with the code above
thangqp
reviewed
Nov 26, 2025
| }, | ||
| [setValue, getValues] | ||
| ); | ||
| // TODO : uncomment when useEffectEvent will be available |
Contributor
There was a problem hiding this comment.
Suggested change
| // TODO : uncomment when useEffectEvent will be available | |
| // TODO : uncomment when useEffectEvent will be available and remove above useEffect |
thangqp
approved these changes
Nov 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
EquipmentTypesByFiltersContingencyListFilterBasedFormto usePanelGroupfor resizable panels.TODO :