Skip to content

Conversation

@Mathieu-Deharbe
Copy link
Contributor

@Mathieu-Deharbe Mathieu-Deharbe commented Oct 31, 2025

PR Summary

Various ui improvements in the limit set interface :

  • updates on the "burger menu" in the tabs
  • right click contextual menu to display delete/duplicate/rename Menu
  • backgrounds
    • hover effects
  • ...

Mathieu-Deharbe and others added 4 commits October 31, 2025 15:08
Signed-off-by: Mathieu DEHARBE <mathieu.deharbe@rte-france.com>
Signed-off-by: Mathieu DEHARBE <mathieu.deharbe@rte-france.com>
Signed-off-by: Mathieu DEHARBE <mathieu.deharbe@rte-france.com>
github-actions[bot]

This comment was marked as outdated.

Mathieu-Deharbe and others added 12 commits November 12, 2025 15:32
Signed-off-by: Mathieu DEHARBE <mathieu.deharbe@rte-france.com>
Signed-off-by: Mathieu DEHARBE <mathieu.deharbe@rte-france.com>
Signed-off-by: Mathieu DEHARBE <mathieu.deharbe@rte-france.com>
Signed-off-by: Mathieu DEHARBE <mathieu.deharbe@rte-france.com>
Signed-off-by: Mathieu DEHARBE <mathieu.deharbe@rte-france.com>
Signed-off-by: Mathieu DEHARBE <mathieu.deharbe@rte-france.com>
Signed-off-by: Mathieu DEHARBE <mathieu.deharbe@rte-france.com>
Signed-off-by: Mathieu DEHARBE <mathieu.deharbe@rte-france.com>
Signed-off-by: Mathieu DEHARBE <mathieu.deharbe@rte-france.com>
Signed-off-by: Mathieu DEHARBE <mathieu.deharbe@rte-france.com>
Copy link
Contributor

@flomillot flomillot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just few remarks as discussed :

small glitch when we rename an element

Screencast.from.2025-11-20.11-04-07.webm

the hover effect of this button is not round

Image

maybe a small padding to the button?

Image

Mathieu-Deharbe and others added 4 commits November 25, 2025 14:40
Signed-off-by: Mathieu DEHARBE <mathieu.deharbe@rte-france.com>
Signed-off-by: Mathieu DEHARBE <mathieu.deharbe@rte-france.com>
Signed-off-by: Mathieu DEHARBE <mathieu.deharbe@rte-france.com>
@Mathieu-Deharbe
Copy link
Contributor Author

Mathieu-Deharbe commented Nov 25, 2025

Just few remarks as discussed :

small glitch when we rename an element

Screencast.from.2025-11-20.11-04-07.webm
the hover effect of this button is not round

Image maybe a small padding to the button? Image

I did the 2nd and third : 1d7280f

The first has been corrected By Bassel in an other ticket.

Signed-off-by: Mathieu DEHARBE <mathieu.deharbe@rte-france.com>
Copy link
Contributor

@basseche basseche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Ok, Test Ok but you should respect the figma image for components order.

Mathieu-Deharbe and others added 2 commits November 27, 2025 16:09
Signed-off-by: Mathieu DEHARBE <mathieu.deharbe@rte-france.com>
Copy link
Contributor

@flomillot flomillot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not retested since last time, code OK but just few remarks

Mathieu-Deharbe and others added 3 commits November 28, 2025 09:28
Co-authored-by: Florent MILLOT <75525996+flomillot@users.noreply.github.com>
Signed-off-by: Mathieu DEHARBE <mathieu.deharbe@rte-france.com>
@sonarqubecloud
Copy link

@Mathieu-Deharbe Mathieu-Deharbe merged commit f643fc6 into main Nov 28, 2025
5 checks passed
@Mathieu-Deharbe Mathieu-Deharbe deleted the limitsets-ui-improvements branch November 28, 2025 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants