Add specific parameters management #163
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feat(): Add specific parameters for shortcircuit computation Signed-off-by: sBouzols <sylvain.bouzols@gmail.com>
Signed-off-by: sBouzols <sylvain.bouzols@gmail.com>
Signed-off-by: sBouzols <sylvain.bouzols@gmail.com>
Signed-off-by: sBouzols <sylvain.bouzols@gmail.com>
Signed-off-by: sBouzols <sylvain.bouzols@gmail.com>
Signed-off-by: sBouzols <sylvain.bouzols@gmail.com>
…e/shortcircuit-server into add_specific_parameters
Signed-off-by: sBouzols <sylvain.bouzols@gmail.com>
Signed-off-by: sBouzols <sylvain.bouzols@gmail.com>
Signed-off-by: sBouzols <sylvain.bouzols@gmail.com>
Signed-off-by: sBouzols <sylvain.bouzols@gmail.com>
…ific parameters Signed-off-by: sBouzols <sylvain.bouzols@gmail.com>
Signed-off-by: sBouzols <sylvain.bouzols@gmail.com>
Signed-off-by: sBouzols <sylvain.bouzols@gmail.com>
sBouzols
changed the title
Signed-off-by: sBouzols <sylvain.bouzols@gmail.com>
Contributor
|
I think we can fix 2 out of the 5 sonar issues |
antoinebhs
reviewed
Nov 19, 2025
src/main/java/org/gridsuite/shortcircuit/server/dto/ShortCircuitParametersValues.java
Show resolved
Hide resolved
antoinebhs
reviewed
Nov 19, 2025
...a/org/gridsuite/shortcircuit/server/entities/parameters/ShortCircuitParametersConstants.java
Show resolved
Hide resolved
antoinebhs
reviewed
Nov 19, 2025
...java/org/gridsuite/shortcircuit/server/entities/parameters/ShortCircuitParametersEntity.java
Outdated
Show resolved
Hide resolved
antoinebhs
reviewed
Nov 19, 2025
...java/org/gridsuite/shortcircuit/server/entities/parameters/ShortCircuitParametersEntity.java
Outdated
Show resolved
Hide resolved
antoinebhs
reviewed
Nov 19, 2025
src/main/java/org/gridsuite/shortcircuit/server/service/ShortCircuitParametersService.java
Outdated
Show resolved
Hide resolved
antoinebhs
reviewed
Nov 19, 2025
src/main/java/org/gridsuite/shortcircuit/server/service/ShortCircuitParametersService.java
Show resolved
Hide resolved
antoinebhs
reviewed
Nov 19, 2025
src/main/java/org/gridsuite/shortcircuit/server/service/ShortCircuitParametersService.java
Outdated
Show resolved
Hide resolved
antoinebhs
reviewed
Nov 19, 2025
src/main/java/org/gridsuite/shortcircuit/server/service/ShortCircuitParametersService.java
Outdated
Show resolved
Hide resolved
antoinebhs
reviewed
Nov 19, 2025
| if (result) { | ||
| parametersRepository.deleteById(parametersUuid); | ||
| } | ||
| return result; |
Contributor
There was a problem hiding this comment.
in other services we directly
parametersRepository.deleteById(parametersUuid);
Contributor
Author
There was a problem hiding this comment.
it allows REST API to return ResponseEntity.notFound() otherwise you get a 200 returned code even if the parameters don't exist. it uses repository existsById method which is lighter than a complete findById. I think it's ok like that. Something to do in other services I think
antoinebhs
reviewed
Nov 19, 2025
| if (getParameters() == null || getParameters().specificParameters() == null || getParameters().specificParameters().isEmpty()) { | ||
| return params; // no specific ShortCircuit params | ||
| } | ||
| return params; |
Contributor
There was a problem hiding this comment.
why don't you need the part with the extension?
Extension<LoadFlowParameters> specificParametersExtension = lfProvider.loadSpecificParameters(PlatformConfig.defaultConfig())
.orElseThrow(() -> new PowsyblException("Cannot add specific loadflow parameters with provider " + getProvider()));
params.addExtension((Class) specificParametersExtension.getClass(), specificParametersExtension);
lfProvider.updateSpecificParameters(specificParametersExtension, getParameters().getSpecificParameters());doesn't it always return the default without this?
Contributor
Author
There was a problem hiding this comment.
Ok used, I don't know... maybe computation wasn't taking consideration of specific parameters ? arf, that's bad...
antoinebhs
reviewed
Nov 19, 2025
src/main/java/org/gridsuite/shortcircuit/server/ShortCircuitController.java
Outdated
Show resolved
Hide resolved
Contributor
|
Thanks for making the shortcircuit-server parameters handling more consistent with the rest of the application! |
antoinebhs
reviewed
Nov 19, 2025
src/test/java/org/gridsuite/shortcircuit/server/report/ReportMapperShortCircuitTest.java
Outdated
Show resolved
Hide resolved
antoinebhs
reviewed
Nov 19, 2025
src/test/java/org/gridsuite/shortcircuit/server/service/ShortCircuitWorkerServiceTest.java
Outdated
Show resolved
Hide resolved
antoinebhs
reviewed
Nov 19, 2025
src/test/java/org/gridsuite/shortcircuit/server/ShortCircuitParametersControllerTest.java
Outdated
Show resolved
Hide resolved
…IDER Signed-off-by: sBouzols <sylvain.bouzols@gmail.com>
Signed-off-by: sBouzols <sylvain.bouzols@gmail.com>
Signed-off-by: sBouzols <sylvain.bouzols@gmail.com>
Signed-off-by: sBouzols <sylvain.bouzols@gmail.com>
Signed-off-by: sBouzols <sylvain.bouzols@gmail.com>
Signed-off-by: sBouzols <sylvain.bouzols@gmail.com>
Signed-off-by: sBouzols <sylvain.bouzols@gmail.com>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat(): Add specific parameters for shortcircuit computation
refactor(): parameters management adaptation from loadflow-server