Skip to content

fix issue 1280#1364

Merged
Albkat merged 1 commit intogrimme-lab:mainfrom
chselz:fix_issue_1280
Dec 3, 2025
Merged

fix issue 1280#1364
Albkat merged 1 commit intogrimme-lab:mainfrom
chselz:fix_issue_1280

Conversation

@chselz
Copy link
Copy Markdown
Contributor

@chselz chselz commented Nov 24, 2025

Should fix issue #1280

I compiled it using meson and ifort compiler. For me it worked then using water as an example

3

O 0.000000 0.000000  0.000000
H 0.758602 0.000000  0.504284
H 0.260455 0.000000 -0.872893

Signed-off-by: Christian Selzer <cselzer@uni-bonn.de>
@chselz
Copy link
Copy Markdown
Contributor Author

chselz commented Nov 24, 2025

@foxtran do you have an idea why CI fails? I don't see how my changes could have affected the cpcm-x test.

@foxtran
Copy link
Copy Markdown
Contributor

foxtran commented Nov 24, 2025

See #1325

@foxtran
Copy link
Copy Markdown
Contributor

foxtran commented Nov 24, 2025

In fact, it fails not randomly. As far as I remember, that is happening because cpx uses files in API and they can be overwritten by concurrent jobs.

@foxtran
Copy link
Copy Markdown
Contributor

foxtran commented Nov 24, 2025

You can try to run xtb/cpx + one of xtb/tblite or xtb/gfn2 or xtb/gfnff test and get this error manually.

Copy link
Copy Markdown
Member

@lmseidler lmseidler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in principal this is not the place to handle this but everything else requires a better design aka larger refactor so this is ok

@lmseidler
Copy link
Copy Markdown
Member

lmseidler commented Nov 26, 2025

In set_logicals you could check using getValue whether the --nfinal flag was set, as you do for setting nopt in the first place in set_docking (where you now set the new logical). This avoids introducing the new logical.

Copy link
Copy Markdown
Member

@Albkat Albkat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Albkat Albkat merged commit 08cc694 into grimme-lab:main Dec 3, 2025
65 of 67 checks passed
@chselz chselz deleted the fix_issue_1280 branch December 3, 2025 12:42
lmseidler pushed a commit to lmseidler/xtb that referenced this pull request Jan 27, 2026
Signed-off-by: Christian Selzer <cselzer@uni-bonn.de>
Co-authored-by: Christian Selzer <cselzer@uni-bonn.de>
Signed-off-by: lmseidler <seidler118@gmail.com>
lmseidler pushed a commit to lmseidler/xtb that referenced this pull request Jan 27, 2026
Signed-off-by: Christian Selzer <cselzer@uni-bonn.de>
Co-authored-by: Christian Selzer <cselzer@uni-bonn.de>
Signed-off-by: lmseidler <seidler118@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants