Open
Conversation
Member
|
Thanks! The fix part looks good although I'll wait to see the corresponding change to My only complaint is to linting-related changes and package-lock. I have a strong preference for keeping such things separate from functionality PRs. As for whitespace, unless you are proposing changing lint rules to enforce your changes, I'd prefer to skip whitespace tweaks, or else it can become a tug of war between people with different editor settings. |
Author
|
HiRegarding lint, package lock and white space : change what ever you want. Vscode did this automatically and it took me too much time to change it all back.Interface checker will come in the afternoon, I have to send time with my children first 😀Op 20 apr 2024 om 09:31 heeft Dmitry ***@***.***> het volgende geschreven:
Thanks! The fix part looks good although I'll wait to see the corresponding change to ts-interface-checker.
My only complaint is to linting-related changes and package-lock. I have a strong preference for keeping such things separate from functionality PRs. As for whitespace, unless you are proposing changing lint rules to enforce your changes, I'd prefer to skip whitespace tweaks, or else it can become a tug of war between people with different editor settings.
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you authored the thread.Message ID: ***@***.***>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
also updated ts-interface-checker