Added support for OpenFFBoard wheel angle lock#43
Open
Ultrawipf wants to merge 5 commits intogro-ove:masterfrom
Open
Added support for OpenFFBoard wheel angle lock#43Ultrawipf wants to merge 5 commits intogro-ove:masterfrom
Ultrawipf wants to merge 5 commits intogro-ove:masterfrom
Conversation
Author
|
At the moment we are working on the command system which may change the HID system so as this is not merged yet hold off for some time until the command structure is finalized. Still many users would like to have the wheel angle setting automated directly from the Content Manager :) |
Ultrawipf
force-pushed
the
openffboard_support
branch
from
a6e12cf to
51a69c4
Compare
Author
|
Rebased on master branch again and build seems to succeed now |
|
@gro-ove ping. Maybe you could merge this change? It would be awesome! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds support to change the wheel lock and scale angle for the OpenFFBoard firmware.
Controlling the FFBoard via HID is still experimental but its confirmed to work in the latest version.
I have a few things to confirm:
when is the isReset flag set? When returning to the main menu/leaving?
It seems to also send the angle set in the main menu.
Would you prefer using this value or resetting it to the default/last value in the device?
Both would be possible.
Check does not seem to find the dependencies.
Same for me when i manually compiled it with VS2019 until i set the include paths.
Did not include these changes in the commit to not cause incompatibilities with your version and only included the actual wheel angle code.