Conversation
FIXME: - @import GRMustache does not work in both test targets. - tests for private APIs in iOS tests won't compile.
…e that links against the framework, another one that tests private APIs).
GRMustache now uses valueForKey: for safe keys (properties and Core Data attributes). objectForKeyedSubscript: is no longer tried first. Classes can override this behavior by implementing the valueForMustacheKey: of the GRMustacheKeyValueCoding protocol. In all cases, NSUndefinedKeyException is caught and swallowed. This commit provides a definitive answer to issue #66.
Ignore the "The empty string should be used when the named partial is not found." test, because in GRMustache, missing templates are an error.
Merged
Conflicts: src/classes/Shared/GRMustacheError.h
Open
… main bundle. Remove support for current template repository (flawed), and current content type (leave it to the user).
…ngWithAllowedCharacters:] (fixes #98)
… context stack lookup (related issue: #66)
|
Using the framework branch currently. Any idea when the 8.0.0 release will be done? |
Owner
Author
|
I've been lazy recently, i'm sorry. I'll try to make it this week-end. The longest remaining part is actually updating the documentation. |
|
Anything I can do to help get v8 out the door? I just noticed I'm still pointing to the framework branch which is undesirable. |
Owner
Author
|
Thanks for your help proposal, @danielphillips. Let me gather my thoughts. |
|
Hi @groue, can I do anything to help? 8.0.0 looks great Small question:
Is there a specific reason that you are thinking of dropping the short syntax? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GRMustache v8.0.0 (follow up to PR #97)
New
Fixed
Breaking Changes
first,lastandcountkeys.first,lastandcountkeys.firstandcountkeys.lengthkey.zipstandard library filter.{{#partial}}...{{/partial}}provides dynamic template inheritance.{{#x}}...{{^x}}...{{/x}}short syntax.+[GRMustacheTemplate templateFromString:error:]does no longer look for partials in main bundle's resources.objectForKeyedSubscript:for objects that respond to this protocol. This behavior now requires explicit conformance to GRMustacheKeyValueCoding.