Fix start signal timing #4
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous version has a problem where the start signal is pulsed high at the end of a read sequence. This causes unintuitive behaviour when attempting to change the sensor's sensitivity using the method suggested in the datasheet, which is to adjust the width of the initial start pulse. A variable 'integrationTime' has been added to indicate how the sensitivity should be changed, and the incorrectly timed start pulse has been removed. The delay between the start signal going low and the start of the reading of data has also been consolidated into one loop, and the comment changed to better identify the delay's purpose.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous version has a problem where the start signal is pulsed high at the end of a read sequence. This causes unintuitive behaviour when attempting to change the sensor's sensitivity using the method suggested in the datasheet, which is to adjust the width of the initial start pulse. A variable 'integrationTime' has been added to indicate how the sensitivity should be changed, and the incorrectly timed start pulse has been removed. The delay between the start signal going low and the start of the reading of data has also been corrected and consolidated into one loop, and the comment changed to better identify the delay's purpose.