feat: add an ansi theme

[autra]

This adds a theme that uses user defined colors in the terminal, so that framework-tool-tui is consistent with system themes.

Fix #96

[autra]

note: I used the numbers that looks good with my theme, but maybe some of them must be changed to match other themes. I'd welcome if someone with another theme can test this.

[grouzen]

This is how it looks for me

[autra]

Mmmhh not great. I need to revisit that.

[grouzen]

Hi! I'm happy to merge it once the CI is fixed.
I think it is related to #80

[autra]

with another light theme (github):

With gruvbox-dark-hard:

Seems ok to me, so maybe indeed it is #80 indeed

[alerque]

I would support this being the default! I suspect most people that have gone to the trouble of setting up a color scheme in their terminal uses it because they like it and are used to it. This brings the app features into focus instead of having to try to interpret what the color scheme is about.

[grouzen]

I would support this being the default! I suspect most people that have gone to the trouble of setting up a color scheme in their terminal uses it because they like it and are used to it. This brings the app features into focus instead of having to try to interpret what the color scheme is about.

Sounds good to me. I don't mind making ANSI the default. In this case, we might want to rename it to Default and place it first in the list.

[autra]

Nice, glad you like this! I made some adaptations to make it look like the already present gruvbox theme, when I use the same theme in the terminal.

[autra]

And I renamed it default and made it the default.

[tripplehelix]

Once this has been merged (or before) we'll need to move the Framework theme into alphabetical order.

Should Default take its place first in the list or should it also be alphabetical? - Or is there a different system we should use?

[grouzen]

Once this has been merged (or before) we'll need to move the Framework theme into alphabetical order.

Should Default take its place first in the list or should it also be alphabetical? - Or is there a different system we should use?

I think it should go first in the list. The rest of them must be in alphabetical order (just my opinion).

[tripplehelix]

The rest of them must be in alphabetical order (just my opinion).

Agreed

Dracula -> Framework -> Game Boy

You may need to modify the tests in /src/tui.rs, reordering the lists in that file then if need be modify what the tests should see.

I have also been trying to keep the themes in /src/tui/theme.rs in alphabetical order to keep it all tidy. Especially as @grouzen wants to add custom themes.

I can add a PR to your repo if you'd like me to apply this fix.

[tripplehelix]

The unselected boarders are very similar to the background for me... is there a brighter colour you could use?

Brightness should be yellow

Default is not a good name, as rust kicks up errors... Maybe just use "Ansi"?

[grouzen]

The unselected boarders are very similar to the background for me... is there a brighter colour you could use?

Brightness should be yellow

Same in my case.
But I think the idea is that it is kind of our problem, and we need to tweak our terminal colours to make it work.
Given this, I'm personally fine with how @autra put it.
However, all this makes me think it might be a bad idea to make the ANSI theme the default, because depending on the terminal settings, borders or other elements might be invisible to a new user after installing the app.

[autra]

But I think the idea is that it is kind of our problem, and we need to tweak our terminal colours to make it work.

Actually, For designing this theme, I used the base16 convention. It is widely used, but AFAIK not an universal convention. The way I did it, it is guaranteed to display well for those themes, but will it display ok with - for instance - the default ubuntu theme?

Maybe we should not use color n° 16 for the default theme, and have another theme for base16 terminal theme?

I will test on a default installation of ubuntu to check. I can test other distro as well.

[tripplehelix]

My screenshot was from the TTY. Which is probably where it should work no?

[grouzen]

My screenshot was from the TTY. Which is probably where it should work no?

It makes sense too.