Updates to goog.module and ES2015#6
Updates to goog.module and ES2015#6itsthesteve wants to merge 2 commits intogrowthemes:masterfrom itsthesteve:guideline-alignment
Conversation
itsthesteve
commented
Feb 21, 2017
itsthesteve
commented
- Bump Angular version to 1.6.1
- Leverages goog.module and ES2015
- Version pin closure sources
- Boilerplate samples
- Leverages goog.module - Sample boilerplate - Bump Angular version to 1.6.1 - Version pin closure sources - ES2015 syntax
|
Looks great - thanks! Since this scaffold is so opinionated, I'm thinking that we're going to need to rename it to something like Everything looks pretty good but I did want to note that it assumes that the user has |
| - 2.7 | ||
| - 2.7 | ||
| node_js: | ||
| - "6.2" |
There was a problem hiding this comment.
We should bump this to 6.9.5
| - "6.2" | ||
| cache: pip | ||
| before_install: | ||
| - nvm install 6.2 |
| - npm install -g gulp | ||
| - npm install -g bower | ||
| - pip install grow | ||
| - nvm use 6.2 |
| "name": "scaffold", | ||
| "private": true, | ||
| "engines": { | ||
| "node": "^6.2.0" |
| "node": "^6.2.0" | ||
| }, | ||
| "devDependencies": { | ||
| "bower": "^1.3.12", |
There was a problem hiding this comment.
This is more of a personal preference, but I'd pin versions
| @@ -1,11 +1,10 @@ | |||
| grow_version: ">=0.0.60" | |||
| grow_version: ">=0.0.67" | |||
| @@ -0,0 +1,6 @@ | |||
| <?xml version="1.0" encoding="UTF-8"?> | |||
|
We should also look at |
3 participants
