Skip to content

logging issues #259

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
recscse merged 1 commit into from
Apr 10, 2026
Merged

logging issues #259

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 12 additions & 3 deletions core/production_logging.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -260,7 +260,10 @@ def __init__(self, app_name: str = "TradingBot", log_level: str = "WARNING"):
def setup_application_logger(self, log_level: str):
"""Set up main application logger"""
logger = logging.getLogger()
level = getattr(logging, log_level.upper())

# Map 'SILENT' or invalid levels to CRITICAL or WARNING
level_map = {'SILENT': logging.CRITICAL, 'NONE': logging.CRITICAL, 'OFF': logging.CRITICAL}
level = level_map.get(log_level.upper(), getattr(logging, log_level.upper(), logging.WARNING))
logger.setLevel(level)

# Remove default handlers
Expand Down Expand Up @@ -296,7 +299,10 @@ def setup_trading_logger(self, log_level: Optional[str] = None):

# Use provided level, or current instance level, or default to WARNING
effective_level = log_level or os.getenv('LOG_LEVEL', 'WARNING')
level = getattr(logging, effective_level.upper())

# Map 'SILENT' or invalid levels to CRITICAL or WARNING
level_map = {'SILENT': logging.CRITICAL, 'NONE': logging.CRITICAL, 'OFF': logging.CRITICAL}
level = level_map.get(effective_level.upper(), getattr(logging, effective_level.upper(), logging.WARNING))
trading_logger.setLevel(level)

# Trading operations log (non-production only)
Expand Down Expand Up @@ -368,7 +374,10 @@ def setup_performance_logger(self, log_level: Optional[str] = None):

# Use provided level, or current instance level, or default to WARNING
effective_level = log_level or os.getenv('LOG_LEVEL', 'WARNING')
level = getattr(logging, effective_level.upper())

# Map 'SILENT' or invalid levels to CRITICAL or WARNING
level_map = {'SILENT': logging.CRITICAL, 'NONE': logging.CRITICAL, 'OFF': logging.CRITICAL}
level = level_map.get(effective_level.upper(), getattr(logging, effective_level.upper(), logging.WARNING))
perf_logger.setLevel(level)


Expand Down
Loading