Skip to content

test: stabilize ThemeToggle localStorage unit tests#20

Open
stokelykent-stack wants to merge 164 commits intogrp06:mainfrom
stokelykent-stack:nightly/2026-02-04-fix-theme-toggle-localstorage
Open

test: stabilize ThemeToggle localStorage unit tests#20
stokelykent-stack wants to merge 164 commits intogrp06:mainfrom
stokelykent-stack:nightly/2026-02-04-fix-theme-toggle-localstorage

Conversation

@stokelykent-stack
Copy link

@stokelykent-stack stokelykent-stack commented Feb 4, 2026 •
edited
Loading

Fix ThemeToggle unit tests that can fail in some JS DOM shims where window.localStorage is only partially implemented (missing clear() / removeItem()).

What changed

  • Define a small Storage-like localStorage mock in tests/unit/themeToggle.test.ts via Object.defineProperty(window, "localStorage", …)
  • Keeps the intent the same: persist theme on toggle + read stored theme on mount

Why

  • npm test was failing with TypeError: window.localStorage.clear is not a function.

grp06 added 30 commits January 28, 2026 19:44
@grp06
more reliable
c7bb9e2
@grp06
Milestone 1: Add project and tile resolution helpers
c853e82
@grp06
Milestone 2: Use shared project and tile resolution in API routes
2fd6772
@grp06
Archive execplan: consolidate project and tile resolution
cc90c5d
@grp06
Docs: update architecture after resolution helper
db73bc1
@grp06
Milestone 1: centralize clawdbot path helpers
5e7b566
@grp06
Milestone 2: apply consolidated path helpers
600dd67
@grp06
Update architecture docs for path resolution
786f479
@grp06
Milestone 1: add ProjectsStore normalization helper
bcec85c
@grp06
Milestone 2: use shared ProjectsStore normalization
3c49cea
@grp06
Archive ProjectsStore execplan
22cd054
@grp06
Update architecture docs for ProjectsStore normalization
eaae9ec
@grp06
Milestone 1: add shared workspace file helpers
b63aef5
@grp06
Milestone 2: reuse workspace file helpers
62961d6
@grp06
Archive workspace file helpers execplan
70eedd6
@grp06
Update architecture docs for workspace file helpers
38d18bf
@grp06
Milestone 1: add agent-canvas path helper
8bc41c6
@grp06
Milestone 2: use shared agent-canvas path
c02f58d
@grp06
Archive agent-canvas path execplan
abab20b
@grp06
Update architecture docs for agent-canvas paths
e2ec627
@grp06
Milestone 1: export Clawdbot agent list helpers
f006b78
@grp06
Milestone 2: reuse shared agent list helpers in heartbeat route
aaa9ebf
@grp06
Docs: archive execplan
049092b
@grp06
Docs: update architecture for shared agent list helpers
66a4f1e
@grp06
Milestone 1: add project store mutation helpers
08ced25
@grp06
Milestone 2: use shared store mutation helpers in project routes
2bc3b64
@grp06
Docs: archive execplan
1f5675f
@grp06
Docs: note shared store mutation helpers
20df400
@grp06
Milestone 1: add workspace file read/write helpers
6d9a355
@grp06
Milestone 2: reuse workspace file helpers in API route
5878564
grp06 and others added 28 commits February 3, 2026 14:34
@grp06
merge active worktree changes from 1cf3
f8a51f6
@grp06
refactor: remove canvas mode and rename focused agent workspace
10f6205
@grp06
Remove canvas-era state and legacy workspace modules
f25e6ac
@grp06
Fix lazy studio session creation lifecycle
44d670e
@grp06
Merge commit '44d670e'
ca9b4cb
@grp06
Fix thinking traces to render per chat turn
2e0cfba
@grp06
Unify thinking traces into a single Thinking section
bab7d60
@grp06
Fix studio session persistence and prune duplicate studio keys
3347a25
@grp06
Merge codex/studio-session-persistence-prune
9c53a5e
@grp06
feat: redesign studio UI with industrial editorial theme
21cc030
@grp06
Merge branch 'codex/frontend-industrial-console-refresh'
3188ba5
@grp06
better ui
8422de1
@grp06
docs: sync architecture after gateway settings path consolidation
f317d08
@grp06
refactor: unify studio settings persistence via shared coordinator
0fe085c
@grp06
docs: sync architecture with studio session settings flow
6f12d28
@grp06
docs: clarify immediate studio session patch in architecture flow
d589cfb
@grp06
Milestone 1: remove dead local config mutation APIs
bad6493
@grp06
Milestone 2: consolidate discord local config list mutations
ea0fadd
@grp06
Milestone 3: finalize local config mutation consolidation
3627ed3
@grp06
docs: narrow local config mutation boundary in architecture
d1d711e
@grp06
Milestone 1: add shared agents.list config helpers
86efea0
@grp06
Milestone 2: migrate config modules to shared agents.list helpers
44310a4
@grp06
Milestone 3: validate agents.list helper consolidation
fc098bc
@grp06
Milestone 1: add runtime event bridge helpers
a12d970
@grp06
Milestone 2: route page runtime listeners through event bridge
70fbd3b
@grp06
Milestone 3: validate runtime event bridge consolidation
9834601
@grp06
update theme
a5c8fa0
test: mock localStorage for ThemeToggle unit tests
1ea9471
sioakim pushed a commit to sioakim/openclaw-studio that referenced this pull request Mar 2, 2026
fix: production build + lint + test fixes
1b7f270 
- Wrap root page in Suspense boundary to fix useSearchParams() build error
- Fix React hooks memoization lint blockers (destructure stable params)
- Stabilize ThemeToggle localStorage unit tests with full Storage mock

Cherry-picked from upstream PRs grp06#88, grp06#86, grp06#20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@stokelykent-stack @grp06