Skip to content

ci: add GitHub Actions workflow for lint, typecheck, and unit tests#90

Open
iminierai-aig wants to merge 1 commit intogrp06:mainfrom
iminierai-aig:feat/add-ci-workflow
Open

ci: add GitHub Actions workflow for lint, typecheck, and unit tests#90
iminierai-aig wants to merge 1 commit intogrp06:mainfrom
iminierai-aig:feat/add-ci-workflow

Conversation

@iminierai-aig
Copy link
Contributor

Closes #83

Summary

  • Add GitHub Actions CI workflow for lint, typecheck, and unit tests
  • Matrix tests across Node 20 and 22
  • Runs on PRs to main and pushes to main

Testing

AI-assisted

  • AI-assisted

Closes grp06#83

- Runs on PRs and pushes to main
- Matrix tests across Node 20 and 22
- Covers lint, typecheck, and unit tests
- Skips e2e (known failures on main, tracked in grp06#84)
Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 6ed206a76d

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

cache: 'npm'

- name: Install dependencies
run: npm ci

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Avoid SSH-only dependency fetch in CI install step

Running npm ci here will fail on GitHub-hosted runners that do not have an SSH key for git@github.com, because the lockfile currently pins @multiavatar/multiavatar to git+ssh://git@github.com/... (package-lock.json line 1718). In that environment the install step blocks or errors before lint/typecheck/tests execute, so this workflow cannot reliably pass for normal PR validation (especially from forks).

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add GitHub Actions CI for lint, typecheck, and unit tests

1 participant