ci: add GitHub Actions workflow for lint, typecheck, and unit tests#90
ci: add GitHub Actions workflow for lint, typecheck, and unit tests#90iminierai-aig wants to merge 1 commit intogrp06:mainfrom
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6ed206a76d
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| cache: 'npm' | ||
|
|
||
| - name: Install dependencies | ||
| run: npm ci |
There was a problem hiding this comment.
Avoid SSH-only dependency fetch in CI install step
Running npm ci here will fail on GitHub-hosted runners that do not have an SSH key for git@github.com, because the lockfile currently pins @multiavatar/multiavatar to git+ssh://git@github.com/... (package-lock.json line 1718). In that environment the install step blocks or errors before lint/typecheck/tests execute, so this workflow cannot reliably pass for normal PR validation (especially from forks).
Useful? React with 👍 / 👎.
Closes #83
Summary
Testing
npm run lintnpm run typechecknpm run test(790/790 passing)npm run e2e(known failures on main, tracked in E2E disconnected-state suite is stale/flaky on main (12/12 failures) #84)AI-assisted