grpc: introduce new DialOption and ServerOption to configure initial window size without disabling BDP estimation. #8283
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #8283 +/- ##
==========================================
- Coverage 82.25% 82.15% -0.10%
==========================================
Files 417 419 +2
Lines 41356 42014 +658
==========================================
+ Hits 34017 34517 +500
- Misses 5923 6024 +101
- Partials 1416 1473 +57
🚀 New features to boost your workflow:
|
|
Is this the same as #8279? Should the original PR be closed? |
|
@dfawley Can you please review this when you get a chance? |
vinothkumarr227
changed the title
purnesh42H
changed the title
purnesh42H
added
Type: Feature
dfawley
reviewed
May 21, 2025
Comment on lines
+151
to
+153
| // TestJoinDialOption_StaticConnAndStreamWindowSizes verifies that both static | ||
| // stream and connection window sizes set via joined dial options are correctly | ||
| // applied. |
There was a problem hiding this comment.
Is there some special interaction here with these and Join? I don't think there's much need for this test, since it just tests Join, but we already have a test for that.
Comment on lines
+228
to
+229
| // WithStaticStreamWindowSize returns a DialOption to set the static initial | ||
| // stream window size. |
There was a problem hiding this comment.
Suggested change
| // WithStaticStreamWindowSize returns a DialOption to set the static initial | |
| // stream window size. | |
| // WithStaticStreamWindowSize returns a DialOption which sets the initial | |
| // stream window size to the value provided and prevents dynamic flow control | |
| // from adjusting it. |
| StatsHandlers []stats.Handler | ||
| KeepaliveParams keepalive.ServerParameters | ||
| KeepalivePolicy keepalive.EnforcementPolicy | ||
| InitialWindowSize int32 |
There was a problem hiding this comment.
I think it would help things for this change if we were to delete the Initial things from our internals for now. Conceptually, the current settings are just renamed to Static.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #7923
Added new
DialOptions to configure static window sizes without disabling BDP estimation:WithStaticStreamWindowSize(int32)— sets the initial stream window sizeWithStaticConnWindowSize(int32)— sets the initial connection window sizeAdded new
ServerOptions to configure static window sizes without disabling BDP estimation:StaticStreamWindowSize(int32)— sets the initial stream window sizeStaticConnWindowSize(int32)— sets the initial connection window sizeThese options mirror the behavior of
WithInitialWindowSizeandInitialConnWindowSize,. The original options will continue to disable BDP estimation as before.RELEASE NOTES: