Cardinality violations in Client streaming and Unary RPC. #8330
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #8330 +/- ##
==========================================
- Coverage 82.25% 82.15% -0.11%
==========================================
Files 417 419 +2
Lines 41356 42025 +669
==========================================
+ Hits 34017 34524 +507
- Misses 5923 6031 +108
- Partials 1416 1470 +54
🚀 New features to boost your workflow:
|
|
@Pranjali-2501 please use the |
dfawley
approved these changes
May 20, 2025
| @@ -3739,6 +3739,39 @@ func (s) TestClientStreaming_ReturnErrorAfterSendAndClose(t *testing.T) { | |||
| } | |||
| } | |||
|
|
|||
| // Tests that a client receives a cardinality violation error for client-streaming | |||
| // RPCs if the server call SendAndClose after calling SendAndClose. | |||
There was a problem hiding this comment.
Suggested change
| // RPCs if the server call SendAndClose after calling SendAndClose. | |
| // RPCs if the server calls SendAndClose multiple times. |
| t.Fatalf("stream.Send(_) = %v, want <nil>", err) | ||
| } | ||
| if _, err := stream.CloseAndRecv(); status.Code(err) != codes.Internal { | ||
| t.Fatalf("stream.CloseAndRecv() = %v, want error %s", err, codes.Internal) |
There was a problem hiding this comment.
Suggested change
| t.Fatalf("stream.CloseAndRecv() = %v, want error %s", err, codes.Internal) | |
| t.Fatalf("stream.CloseAndRecv() = %v, want error with status code %s", err, codes.Internal) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Client should ensure an
INTERNALerror is returned for non-server streaming RPCs if the server attempts to send more than one response.Currently it is returning
UNKNOWN, which should not be the case for cardinality violations.Filed in #7286
RELEASE NOTES: N/A