Skip to content

Add flag guarding SPIFFE Bundle provider #8343

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

gtcooke94
Copy link
Contributor

@gtcooke94 gtcooke94 commented May 19, 2025

Per https://github.com/grpc/proposal/blob/master/A87-mtls-spiffe-support.md this feature should be guarded by an environment variable, GRPC_EXPERIMENTAL_XDS_MTLS_SPIFFE

RELEASE NOTES: N/A

@gtcooke94 gtcooke94 added the Type: Security A bug or other problem affecting security label May 19, 2025
@gtcooke94 gtcooke94 added this to the 1.73 Release milestone May 19, 2025
Copy link

codecov bot commented May 19, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.19%. Comparing base (0c24af1) to head (7c30683).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8343      +/-   ##
==========================================
+ Coverage   82.17%   82.19%   +0.01%     
==========================================
  Files         419      419              
  Lines       42034    42041       +7     
==========================================
+ Hits        34541    34555      +14     
+ Misses       6027     6017      -10     
- Partials     1466     1469       +3     
Files with missing lines Coverage Δ
credentials/tls/certprovider/pemfile/watcher.go 86.95% <100.00%> (+0.38%) ⬆️
internal/xds/bootstrap/tlscreds/bundle.go 87.25% <100.00%> (+0.38%) ⬆️

... and 19 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@gtcooke94 gtcooke94 requested a review from eshitachandwani May 20, 2025 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Security A bug or other problem affecting security
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants